netdev - Re: [PATCH] vmxnet3: repair memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123.195839.1025412103690413060.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 19:58:39 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     nhorman@...driver.com
Cc:     netdev@...r.kernel.org, boyang@...hat.com, skhare@...are.com,
        pv-drivers@...are.com
Subject: Re: [PATCH] vmxnet3: repair memory leak

From: Neil Horman <nhorman@...driver.com>
Date: Mon, 22 Jan 2018 16:06:37 -0500

> with the introduction of commit
> b0eb57cb97e7837ebb746404c2c58c6f536f23fa, it appears that rq->buf_info
> is improperly handled.  While it is heap allocated when an rx queue is
> setup, and freed when torn down, an old line of code in
> vmxnet3_rq_destroy was not properly removed, leading to rq->buf_info[0]
> being set to NULL prior to its being freed, causing a memory leak, which
> eventually exhausts the system on repeated create/destroy operations
> (for example, when  the mtu of a vmxnet3 interface is changed
> frequently.
> 
> Fix is pretty straight forward, just move the NULL set to after the
> free.
> 
> Tested by myself with successful results
> 
> Applies to net, and should likely be queued for stable, please
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> Reported-By: boyang@...hat.com

Applied and queued up for -stable, thanks Neil.