netdev - Re: [patch net-next v2 00/10] Add support for resource abstraction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180125152448.GB2159@nanopsycho>
Date:   Thu, 25 Jan 2018 16:24:48 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsa@...ulusnetworks.com>
Cc:     Arkadi Sharshevsky <arkadis@...lanox.com>, netdev@...r.kernel.org,
        roopa@...ulusnetworks.com, davem@...emloft.net, mlxsw@...lanox.com,
        andrew@...n.ch, vivien.didelot@...oirfairelinux.com,
        f.fainelli@...il.com, michael.chan@...adcom.com,
        ganeshgr@...lsio.com, saeedm@...lanox.com, matanb@...lanox.com,
        leonro@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, ast@...nel.org, daniel@...earbox.net,
        simon.horman@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        john.hurley@...ronome.com, alexander.h.duyck@...el.com,
        linville@...driver.com, gospo@...adcom.com,
        steven.lin1@...adcom.com, yuvalm@...lanox.com,
        ogerlitz@...lanox.com
Subject: Re: [patch net-next v2 00/10] Add support for resource abstraction

Thu, Jan 04, 2018 at 05:58:51PM CET, dsa@...ulusnetworks.com wrote:
>On 1/3/18 11:36 AM, Jiri Pirko wrote:
>> Wed, Jan 03, 2018 at 07:29:46PM CET, dsa@...ulusnetworks.com wrote:
>>> On 1/3/18 11:17 AM, Jiri Pirko wrote:
>>>> Wed, Jan 03, 2018 at 07:14:16PM CET, dsa@...ulusnetworks.com wrote:
>>>>> On 1/3/18 11:05 AM, Arkadi Sharshevsky wrote:
>>>>>> As I stated this is a user-space bug which I fixed, and updated my repo
>>>>>> so please pull. Devlink uses mnl,and currently mnl does not support
>>>>>> extended ack. I added support for this in my local ver of libmnl:
>>>>>>
>>>>>> https://github.com/arkadis/libmnl.git
>>>>>>
>>>>>> On branch master, so you can check it out. Besides this bugs, which were
>>>>>> userspace, can please specify what are the pending problems from your
>>>>>> point of view? Thanks!
>>>>>
>>>>> devlink is in iproute2 package and it has extack support. See 'git log
>>>>> lib/libnetlink.c'
>>>>
>>>> Dave, devlink uses libmnl.
>>>>
>>>
>>> Now I remember. You wrote it independently and but needed iproute2 be a
>>> delivery vehicle. It uses none of the common infrastructure from
>>> iproute2. Could we make this more difficult ....
>> 
>> Feel free to rewrite it to use lib/libnetlink.c. Should not be that
>> hard. Note that at the time I was pushing devlink userspace, tipc also
>> used libmnl as a part of iproute2, so devlink was not the first one.
>> That is why I decided not to rewrite.
>> 
>> As of the rest of the "common infrastructure", what exactly do you
>> have in mind?
>> 
>
>This is what I am getting at. Apparently, these resource patches for
>devlink require a patched libmnl to work properly. It is wrong for

What do you mean, "work properly". If there is no patched libmnl, only
thing what happens is that the extack won't be processed and shown.
That is the same behaviour as if you compile iproute2 package without
libmnl - all works, used just don't see extack messages.

I don't see any problem in that. Do you?


>iproute2 to accept this patch and to build a devlink command that we
>know does not work. That means iproute2 needs a dependency on a specific
>version of libmnl - a version which does not yet exist because those
>changes have not been accepted and libmnl version released. Adding that
>dependency is going to inconvenience to all current users of the
>iproute2 repo.