netdev - Re: [RFC] net: qcom/emac: mdiobus-dev fwnode should point to emac-adev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25f763a5-ffcf-c668-105f-6534555c3595@codeaurora.org>
Date:   Thu, 25 Jan 2018 09:40:45 -0600
From:   Timur Tabi <timur@...eaurora.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Wang Dongsheng <dongsheng.wang@...-semitech.com>
Cc:     hpuranik@...eaurora.org, yu.zheng@...-semitech.com,
        netdev@...r.kernel.org, Marcin Wojtas <mw@...ihalf.com>
Subject: Re: [RFC] net: qcom/emac: mdiobus-dev fwnode should point to
 emac-adev

On 01/25/2018 08:15 AM, Andrew Lunn wrote:
> If i'm reading your patch correctly, you are looking for the MDIO
> reset in the MAC node. This is wrong. It is an MDIO property, so
> should be in the MDIO device. Once we have figured out how to
> represent MDIO busses in ACPI, the reset will be in the MDIO node.

Just FYI, the MDIO controller in the EMAC is integrated, so I can't see 
us creating a separate Device Tree or ACPI node/property for it. 
Granted, the code in emac-phy.c:emac_phy_config() that registers the 
MDIO bus is convoluted, so maybe there's an opportunity to replace 
some/all of that code with some generic API.  Maybe we need something 
like acpi_mdiobus_register() like we have of_mdiobus_register().

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.