netdev - Re: [PATCH net-next 1/8] pkt_cls: add new tc cls helper to check offload flag and chain index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180125112652.2d604720@cakuba.netronome.com>
Date:   Thu, 25 Jan 2018 11:26:52 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, dsahern@...il.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next 1/8] pkt_cls: add new tc cls helper to check
 offload flag and chain index

On Thu, 25 Jan 2018 09:03:48 +0100, Jiri Pirko wrote:
> >@@ -144,9 +144,6 @@ int nsim_bpf_setup_tc_block_cb(enum tc_setup_type type,
> > 		return -EOPNOTSUPP;
> > 	}
> > 
> >-	if (cls_bpf->common.chain_index)
> >-		return -EOPNOTSUPP;
> >-  
> 
> For nfp and netdevsim you do this in a patch that introduces the helper,
> for the rest you have a separate patch? Why this inconsistency?
> Again, from my perspective, this can be done in a single patch for all
> drivers. All the same hunks.

Ah, indeed, slightly sloppy.  This patch used to remove the
tc_can_offload_extack() helper hence the conversion here.
Let me split them out.