netdev - Re: [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKvpyk2GhGD5bBz6F5mA881xq7BaAmC4bwMsSwWcAU0bh0TGLQ@mail.gmail.com>
Date:   Thu, 25 Jan 2018 11:22:36 +0530
From:   Sathya Perla <sathya.perla@...adcom.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] cls_flower: check if filter is in HW before calling fl_hw_destroy_filter()

On Wed, Jan 24, 2018 at 9:37 PM, Jiri Pirko <jiri@...nulli.us> wrote:
> Wed, Jan 24, 2018 at 12:42:55PM CET, sathya.perla@...adcom.com wrote:
>>When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns
>>error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags.
>>
>>This flag (via tc_in_hw()) must be checked before issuing the call
>>to delete a filter in HW (fl_hw_destroy_filter()) and before issuing the
>>call to query stats (fl_hw_update_stats()).
>>
>>Signed-off-by: Sathya Perla <sathya.perla@...adcom.com>
>
> 1) You have to indicate what tree you aim this to be applied on:
>    [patch net] or [patch net-next]
> 2) Please provided a "Fixes" line
> 3) Please use scripts/get_maintainer.pl to get the people to cc
> 4) Please aim the fix not only to cls_flower, but to other cls as well.

Ok, will do. thanks!