netdev - [PATCH] net: clean the sk_frag.page of new cloned socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1516882089-28575-1-git-send-email-lirongqing@baidu.com>
Date:   Thu, 25 Jan 2018 20:08:09 +0800
From:   Li RongQing <lirongqing@...du.com>
To:     netdev@...r.kernel.org
Cc:     edumazet@...gle.com
Subject: [PATCH] net: clean the sk_frag.page of new cloned socket

Clean the sk_frag.page of new cloned socket, otherwise it will release
twice wrongly since the reference count of this sk_frag page is not
increased.

sk_clone_lock() is used to clone a new socket from sock which is in
listening state and has not sk_frag.page, but a socket has sent data
and can gets transformed back to a listening socket, will allocate an
tcp_sock through sk_clone_lock() when a new connection comes in.

Signed-off-by: Li RongQing <lirongqing@...du.com>
Cc: Eric Dumazet <edumazet@...gle.com>
---
 net/core/sock.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/sock.c b/net/core/sock.c
index c0b5b2f17412..c845856f26da 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1738,6 +1738,8 @@ struct sock *sk_clone_lock(const struct sock *sk, const gfp_t priority)
 		sk_refcnt_debug_inc(newsk);
 		sk_set_socket(newsk, NULL);
 		newsk->sk_wq = NULL;
+		newsk->sk_frag.page = NULL;
+		newsk->sk_frag.offset = 0;

 		if (newsk->sk_prot->sockets_allocated)
 			sk_sockets_allocated_inc(newsk);
-- 
2.11.0