netdev - Re: [RFC PATCH net-next] sfc: efx_default_channel_want

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f502691-13cc-5128-43dd-36a17ec8bcc2@solarflare.com>
Date:   Fri, 26 Jan 2018 15:13:05 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     kbuild test robot <fengguang.wu@...el.com>,
        David Miller <davem@...emloft.net>
CC:     <kbuild-all@...org>, <netdev@...r.kernel.org>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Bert Kenward <bkenward@...arflare.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be
 static

On 26/01/18 01:03, kbuild test robot wrote:
> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Acked-by: Edward Cree <ecree@...arflare.com>

Dave, can you take this directly or do you need it reposted without RFC tags?  I'm not sure what the procedure is for robopatches.
> ---
>  efx.c |    2 +-
>  ptp.c |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 456866b0..16757cf 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -896,7 +896,7 @@ void efx_schedule_slow_fill(struct efx_rx_queue *rx_queue)
>  	mod_timer(&rx_queue->slow_fill, jiffies + msecs_to_jiffies(100));
>  }
>  
> -bool efx_default_channel_want_txqs(struct efx_channel *channel)
> +static bool efx_default_channel_want_txqs(struct efx_channel *channel)
>  {
>  	return channel->channel - channel->efx->tx_channel_offset <
>  		channel->efx->n_tx_channels;
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 433d29d..3e2c5b1 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -366,7 +366,7 @@ bool efx_ptp_use_mac_tx_timestamps(struct efx_nic *efx)
>  /* PTP 'extra' channel is still a traffic channel, but we only create TX queues
>   * if PTP uses MAC TX timestamps, not if PTP uses the MC directly to transmit.
>   */
> -bool efx_ptp_want_txqs(struct efx_channel *channel)
> +static bool efx_ptp_want_txqs(struct efx_channel *channel)
>  {
>  	return efx_ptp_use_mac_tx_timestamps(channel->efx);
>  }
> @@ -2146,7 +2146,7 @@ static int efx_phc_enable(struct ptp_clock_info *ptp,
>  	return 0;
>  }
>  
> -const struct efx_channel_type efx_ptp_channel_type = {
> +static const struct efx_channel_type efx_ptp_channel_type = {
>  	.handle_no_channel	= efx_ptp_handle_no_channel,
>  	.pre_probe		= efx_ptp_probe_channel,
>  	.post_remove		= efx_ptp_remove_channel,