netdev - Re: [PATCH] VSOCK: set POLLOUT | POLLWRNORM for TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180126.111701.1618019241717200752.davem@davemloft.net>
Date:   Fri, 26 Jan 2018 11:17:01 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stefanha@...hat.com
Cc:     netdev@...r.kernel.org, decui@...rosoft.com, jhansen@...are.com
Subject: Re: [PATCH] VSOCK: set POLLOUT | POLLWRNORM for TCP_CLOSING

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Fri, 26 Jan 2018 11:48:25 +0000

> select(2) with wfds but no rfds must return when the socket is shut down
> by the peer.  This way userspace notices socket activity and gets -EPIPE
> from the next write(2).
> 
> Currently select(2) does not return for virtio-vsock when a SEND+RCV
> shutdown packet is received.  This is because vsock_poll() only sets
> POLLOUT | POLLWRNORM for TCP_CLOSE, not the TCP_CLOSING state that the
> socket is in when the shutdown is received.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>

Applied and queued up for -stable, thank you.