netdev - Re: [PATCHv6 net-next 1/3] net: erspan: use bitfield instead of mask and offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_A=9Z=7_mUubQqDu-FVbN+aRd=3zC7wEPLnkFmoHAK0Wg@mail.gmail.com>
Date:   Thu, 25 Jan 2018 18:35:50 -0800
From:   Pravin Shelar <pshelar@....org>
To:     William Tu <u9012063@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCHv6 net-next 1/3] net: erspan: use bitfield instead of mask
 and offset

On Thu, Jan 25, 2018 at 1:20 PM, William Tu <u9012063@...il.com> wrote:
> Originally the erspan fields are defined as a group into a __be16 field,
> and use mask and offset to access each field.  This is more costly due to
> calling ntohs/htons.  The patch changes it to use bitfields.
>
> Signed-off-by: William Tu <u9012063@...il.com>

Acked-by: Pravin B Shelar <pshelar@....org>

Thanks.