netdev - Re: [PATCH net-next] ptr_ring: fix integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29dd0d30-07e7-0432-2ad8-209a2ed35e5a@redhat.com>
Date:   Fri, 26 Jan 2018 11:44:22 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH net-next] ptr_ring: fix integer overflow



On 2018年01月26日 01:31, Michael S. Tsirkin wrote:
> On Thu, Jan 25, 2018 at 10:17:38PM +0800, Jason Wang wrote:
>>
>> On 2018年01月25日 21:45, Michael S. Tsirkin wrote:
>>> On Thu, Jan 25, 2018 at 03:31:42PM +0800, Jason Wang wrote:
>>>> We try to allocate one more entry for lockless peeking. The adding
>>>> operation may overflow which causes zero to be passed to kmalloc().
>>>> In this case, it returns ZERO_SIZE_PTR without any notice by ptr
>>>> ring. Try to do producing or consuming on such ring will lead NULL
>>>> dereference. Fix this detect and fail early.
>>>>
>>>> Fixes: bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds")
>>>> Reported-by:syzbot+87678bcf753b44c39b67@...kaller.appspotmail.com
>>>> Cc: John Fastabend<john.fastabend@...il.com>
>>>> Signed-off-by: Jason Wang<jasowang@...hat.com>
>>> Ugh that's just way too ugly.
>>> I'll work on dropping the extra + 1 - but calling this
>>> function with -1 size is the real source of the bug.
>>> Do you know how come we do that?
>>>
>> It looks e.g try to change tx_queue_len to UINT_MAX. And we probably can't
>> prevent user form trying to do this?
>>
>> Thanks
> Right. BTW why net-next? Isn't the crash exploitable in net?
>

Commit bcecb4bbf88a exists only in net-next. And in net we check r->size 
before trying to dereference the queue.

Thanks