netdev - Re: [PATCH iproute2] ip: address: fix stats64 JSON object name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180127160809.55824c11@xeon-e3>
Date:   Sat, 27 Jan 2018 16:08:09 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     dsahern@...il.com, oss-drivers@...ronome.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ip: address: fix stats64 JSON object name

On Fri, 26 Jan 2018 11:30:35 -0800
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> The JSON object name for statistics in ip link show is "stats644".
> Looks like a typo, commit d0e720111aad ("ip: ipaddress.c: add support
> for json output") contains an example with the expected "stats64" name.
> 
> The fact that no one has noticed until now is probably an indication
> that no one is using this object.  Hopefully it's not too late to fix
> this, although IIUC this has already been in 4.13 and 4.14 releases :S
> 
> Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> ---
>  ip/ipaddress.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index ba60125c1b78..67ac6bd31373 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -598,7 +598,7 @@ static void print_link_stats64(FILE *fp, const struct rtnl_link_stats64 *s,
>  			       const struct rtattr *carrier_changes)
>  {
>  	if (is_json_context()) {
> -		open_json_object("stats644");
> +		open_json_object("stats64");
>  
>  		/* RX stats */
>  		open_json_object("rx");

Thanks for the bugfix. Applied.