netdev - Re: [PATCH] qlcnic: fix deadlock bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180129.175921.891660239017957935.davem@davemloft.net>
Date:   Mon, 29 Jan 2018 17:59:21 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     junxiao.bi@...cle.com
Cc:     netdev@...r.kernel.org, harish.patil@...ium.com,
        manish.chopra@...ium.com, Dept-GELinuxNICDev@...ium.com
Subject: Re: [PATCH] qlcnic: fix deadlock bug

From: Junxiao Bi <junxiao.bi@...cle.com>
Date: Mon, 29 Jan 2018 17:53:42 +0800

> The following soft lockup was caught. This is a deadlock caused by
> recusive locking.
> 
> Process kworker/u40:1:28016 was holding spin lock "mbx->queue_lock" in
> qlcnic_83xx_mailbox_worker(), while a softirq came in and ask the same spin
> lock in qlcnic_83xx_enqueue_mbx_cmd(). This lock should be hold by disable
> bh..
 ...
> Signed-off-by: Junxiao Bi <junxiao.bi@...cle.com>

Looks good, applied and queued up for -stable.