netdev - Re: [PATCH] devinet_ioctl(): Set ret to 0 when breaking out of the switch-case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALMXkpZxGBH6s2W2TJMRPV-B3t3qDys49OB=1nxXeKg3=rcgXA@mail.gmail.com>
Date:   Sun, 28 Jan 2018 21:16:59 -0800
From:   Christoph Paasch <christoph.paasch@...il.com>
To:     Christoph Paasch <cpaasch@...le.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] devinet_ioctl(): Set ret to 0 when breaking out of the switch-case

On Sun, Jan 28, 2018 at 8:48 PM, Christoph Paasch <cpaasch@...le.com> wrote:
> Commit 03aef17bb79b ("devinet_ioctl(): take copyin/copyout to caller")
> introduced a regression when using ifconfig. ifconfig doesn't show the
> address anymore. The reason is that the above patch changed the flow in
> devinet_ioctl(), where we break; and end up returning ret. ret however
> is set to -EADDRNOTAVAIL, which later on prevents the copy_to_user() in
> inet_ioctl().
>
> Thus, when we break in devinet_ioctl() we have to set ret to 0 to
> properly return out of devinet_ioctl.
>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Christoph Hellwig <hch@....de>
> Fixes: 03aef17bb79b ("devinet_ioctl(): take copyin/copyout to caller")
> Signed-off-by: Christoph Paasch <cpaasch@...le.com>
> ---
>  net/ipv4/devinet.c | 4 ++++
>  1 file changed, 4 insertions(+)

Oh, I hadn't seen that a fix was already posted this morning at
https://patchwork.ozlabs.org/patch/866817/.

You can disregard this patch here. Sorry for the noise.


Christoph