[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d65b56d0-c750-bdc0-6b2f-3cf3c22b6b60@gmail.com>
Date: Mon, 29 Jan 2018 19:58:35 -0700
From: David Ahern <dsahern@...il.com>
To: Stephen Hemminger <stephen@...workplumber.org>,
netdev@...r.kernel.org
Cc: Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [RFC] iproute2: add json and color support
On 1/29/18 1:29 PM, Stephen Hemminger wrote:
> This patch makes ip route command have json and color output in
> a similar fashion of ip link and address.
>
> The printing is split into functions and duplicate code
> removed.
>
> Probably incomplete, and has formatting glitches.
>
> ---
> include/utils.h | 4 +
> ip/iproute.c | 764 ++++++++++++++++++++++++++++++++++----------------------
> 2 files changed, 469 insertions(+), 299 deletions(-)
good idea. 469 insert, 299 delete makes this really complicated.
Splitting this into smaller patches will be helpful.
Powered by blists - more mailing lists