netdev - Re: [PATCH net-next] ptr_ring: fix integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f69970a7-f991-b038-5e9f-701cf6d8ec41@redhat.com>
Date:   Tue, 30 Jan 2018 14:56:11 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     mst@...hat.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, john.fastabend@...il.com
Subject: Re: [PATCH net-next] ptr_ring: fix integer overflow



On 2018年01月30日 01:01, David Miller wrote:
> From: Jason Wang <jasowang@...hat.com>
> Date: Thu, 25 Jan 2018 15:31:42 +0800
>
>> We try to allocate one more entry for lockless peeking. The adding
>> operation may overflow which causes zero to be passed to kmalloc().
>> In this case, it returns ZERO_SIZE_PTR without any notice by ptr
>> ring. Try to do producing or consuming on such ring will lead NULL
>> dereference. Fix this detect and fail early.
>>
>> Fixes: bcecb4bbf88a ("net: ptr_ring: otherwise safe empty checks can overrun array bounds")
>> Reported-by: syzbot+87678bcf753b44c39b67@...kaller.appspotmail.com
>> Cc: John Fastabend <john.fastabend@...il.com>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
> I'm dropping this because I am to understand that Michael Tsirkin's patch
> series covers this issue.

Yes.

>
> Let me know if I still need to apply this.
>
> Thanks.

No need for this.

Thanks