netdev - Re: [PATCH v3 1/2] net: create skb_gso_validate_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Jan 2018 00:59:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Daniel Axtens <dja@...ens.net>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Daniel Axtens <dja@...ens.net>, Manish.Chopra@...ium.com,
        Jason Wang <jasowang@...hat.com>,
        Pravin Shelar <pshelar@....org>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH v3 1/2] net: create skb_gso_validate_mac_len()

Hi Daniel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.15 next-20180126]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Axtens/bnx2x-disable-GSO-on-too-large-packets/20180131-000934
config: i386-randconfig-a1-201804 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/linkage.h:7:0,
                    from include/linux/kernel.h:7,
                    from include/linux/list.h:9,
                    from include/linux/module.h:9,
                    from net/core/skbuff.c:41:
>> net/core/skbuff.c:4968:19: error: 'skb_gso_validate_network_len' undeclared here (not in a function)
    EXPORT_SYMBOL_GPL(skb_gso_validate_network_len);
                      ^
   include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
     extern typeof(sym) sym;      \
                   ^
   net/core/skbuff.c:4968:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
    EXPORT_SYMBOL_GPL(skb_gso_validate_network_len);
    ^

vim +/skb_gso_validate_network_len +4968 net/core/skbuff.c

  4954	
  4955	/**
  4956	 * skb_gso_validate_mtu - Return in case such skb fits a given MTU
  4957	 *
  4958	 * @skb: GSO skb
  4959	 * @mtu: MTU to validate against
  4960	 *
  4961	 * skb_gso_validate_mtu validates if a given skb will fit a wanted MTU
  4962	 * once split.
  4963	 */
  4964	bool skb_gso_validate_mtu(const struct sk_buff *skb, unsigned int mtu)
  4965	{
  4966		return skb_gso_size_check(skb, skb_gso_network_seglen(skb), mtu);
  4967	}
> 4968	EXPORT_SYMBOL_GPL(skb_gso_validate_network_len);
  4969	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29908 bytes)