netdev - Re: [PATCH] net: pxa168_eth: add netconsole support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180131.102039.130340676906752608.davem@davemloft.net>
Date:   Wed, 31 Jan 2018 10:20:39 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     amonakov@...ras.ru
Cc:     netdev@...r.kernel.org, rmk+kernel@....linux.org.uk,
        sebastian.hesselbarth@...il.com, f.fainelli@...il.com
Subject: Re: [PATCH] net: pxa168_eth: add netconsole support

From: Alexander Monakov <amonakov@...ras.ru>
Date: Wed, 31 Jan 2018 17:05:47 +0300 (MSK)

> And is this a matter of efficiency (not calling napi_schedule when there's
> nothing to do and not keeping interrupts enabled for its duration), or also
> a matter of correctness?

If you don't mask interrupts properly around scheduling and finishing
NAPI poll, you can lose events so it is a matter of correctness.