netdev - Re: [RFC][PATCH iproute2-next 2/6] ip: Introduce get_rtnl_link_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180201153206.1e834816@xeon-e3>
Date:   Thu, 1 Feb 2018 15:32:06 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Serhey Popovych <serhe.popovych@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [RFC][PATCH iproute2-next 2/6] ip: Introduce
 get_rtnl_link_stats_rta() to get link statistics

On Thu,  1 Feb 2018 21:40:54 +0200
Serhey Popovych <serhe.popovych@...il.com> wrote:

> +/* Based on copy_rtnl_link_stats() from kernel at net/core/rtnetlink.c */
> +static void copy_rtnl_link_stats64(struct rtnl_link_stats64 *a,
> +				   const struct rtnl_link_stats *b)
> +{
> +	a->rx_packets = b->rx_packets;
> +	a->tx_packets = b->tx_packets;
> +	a->rx_bytes = b->rx_bytes;
> +	a->tx_bytes = b->tx_bytes;
> +	a->rx_errors = b->rx_errors;
> +	a->tx_errors = b->tx_errors;
> +	a->rx_dropped = b->rx_dropped;
> +	a->tx_dropped = b->tx_dropped;
> +
> +	a->multicast = b->multicast;
> +	a->collisions = b->collisions;
> +
> +	a->rx_length_errors = b->rx_length_errors;
> +	a->rx_over_errors = b->rx_over_errors;
> +	a->rx_crc_errors = b->rx_crc_errors;
> +	a->rx_frame_errors = b->rx_frame_errors;
> +	a->rx_fifo_errors = b->rx_fifo_errors;
> +	a->rx_missed_errors = b->rx_missed_errors;
> +
> +	a->tx_aborted_errors = b->tx_aborted_errors;
> +	a->tx_carrier_errors = b->tx_carrier_errors;
> +	a->tx_fifo_errors = b->tx_fifo_errors;
> +	a->tx_heartbeat_errors = b->tx_heartbeat_errors;
> +	a->tx_window_errors = b->tx_window_errors;
> +
> +	a->rx_compressed = b->rx_compressed;
> +	a->tx_compressed = b->tx_compressed;
> +
> +	a->rx_nohandler = b->rx_nohandler;
> +}

You could treat the two structures as arrays since all values are same size.
This avoids any possible skipping of values.