netdev - Re: [PATCH iproute2-next v2 2/6] ipaddress: Simplify print_linkinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4601967d-fc05-1d33-55c0-f36a24a2753d@gmail.com>
Date:   Wed, 31 Jan 2018 20:43:57 -0700
From:   David Ahern <dsahern@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next v2 2/6] ipaddress: Simplify
 print_linkinfo_brief() and it's usage

On 1/30/18 11:09 AM, Serhey Popovych wrote:
> Improve print_linkinfo_brief() and it's callers:
> 
>   1) Get rid of custom @struct filter pointer @pfilter: it is NULL in
>      all callers anyway and global @filter is used.
> 

Looks like I somehow dropped a vrf change that was going to use that.
Send a standalone patch to revert 63891c70137f (straight revert does not
work so some fixup is needed) and then a follow on for the second part
of this change.

>   2) Simplify calling code in ipaddr_list_flush_or_save() by
>      introducing intermediate variable of @struct nlmsghdr, drop
>      duplicated code: print_linkinfo_brief() never returns values other
>      than <= 0 so we can move print_selected_addrinfo() outside of each
>      block.
> 
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>
> ---
>  ip/ip_common.h |    3 +--
>  ip/ipaddress.c |   60 ++++++++++++++++++++++++--------------------------------
>  ip/iplink.c    |    2 +-
>  3 files changed, 28 insertions(+), 37 deletions(-)
>