netdev - Re: [PATCH v4 0/2] bnx2x: disable GSO on too-large packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180201.093622.1451715802440909158.davem@davemloft.net>
Date:   Thu, 01 Feb 2018 09:36:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dja@...ens.net
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        Manish.Chopra@...ium.com, jasowang@...hat.com, pshelar@....org,
        marcelo.leitner@...il.com
Subject: Re: [PATCH v4 0/2] bnx2x: disable GSO on too-large packets

From: Daniel Axtens <dja@...ens.net>
Date: Wed, 31 Jan 2018 14:15:32 +1100

> We observed a case where a packet received on an ibmveth device had a
> GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x
> device, where it caused a firmware assert. This is described in detail
> at [0].
> 
> Ultimately we want a fix in the core, but that is very tricky to
> backport. So for now, just stop the bnx2x driver from crashing.
> 
> When net-next re-opens I will send the fix to the core and a revert
> for this.
> 
> v4 changes:
>   - fix compilation error with EXPORTs (patch 1)
>   - only do slow test if gso_size is greater than 9000 bytes (patch 2)
 ...
> [0]: https://patchwork.ozlabs.org/patch/859410/

Series applied, thanks Daniel.