netdev - Re: [PATCH net] nfp: fix TLV offset calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 02 Feb 2018 19:18:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        edwin.peer@...ronome.com
Subject: Re: [PATCH net] nfp: fix TLV offset calculation

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu,  1 Feb 2018 19:41:43 -0800

> From: Edwin Peer <edwin.peer@...ronome.com>
> 
> The data pointer in the config space TLV parser already includes
> NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect
> offset values were only used in printed user output, rendering
> the bug merely cosmetic.
> 
> Fixes: 73a0329b057e ("nfp: add TLV capabilities to the BAR")
> Signed-off-by: Edwin Peer <edwin.peer@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks Jakub.