netdev - Re: [PATCH net] cls_u32: add missing RCU annotation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180202.192626.1077550990238426722.davem@davemloft.net>
Date:   Fri, 02 Feb 2018 19:26:26 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, john.fastabend@...il.com
Subject: Re: [PATCH net] cls_u32: add missing RCU annotation.

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri,  2 Feb 2018 16:02:22 +0100

> In a couple of points of the control path, n->ht_down is currently
> accessed without the required RCU annotation. The accesses are
> safe, but sparse complaints. Since we already held the
> rtnl lock, let use rtnl_dereference().
> 
> Fixes: a1b7c5fd7fe9 ("net: sched: add cls_u32 offload hooks for netdevs")
> Fixes: de5df63228fc ("net: sched: cls_u32 changes to knode must appear atomic to readers")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied and queued up for -stable.