netdev - Re: [PATCH net] soreuseport: fix mem leak in reuseport_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 02 Feb 2018 19:47:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     ebiggers3@...il.com, kraig@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] soreuseport: fix mem leak in reuseport_add_sock()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 02 Feb 2018 10:27:27 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> reuseport_add_sock() needs to deal with attaching a socket having
> its own sk_reuseport_cb, after a prior
> setsockopt(SO_ATTACH_REUSEPORT_?BPF)
> 
> Without this fix, not only a WARN_ONCE() was issued, but we were also
> leaking memory.
> 
> Thanks to sysbot and Eric Biggers for providing us nice C repros. 
 ...
> Fixes: ef456144da8e ("soreuseport: define reuseport groups")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot+c0ea2226f77a42936bf7@...kaller.appspotmail.com

Applied, thanks.