netdev - Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180205.095851.568720869636736573.davem@davemloft.net>
Date:   Mon, 05 Feb 2018 09:58:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tommi.t.rantala@...ia.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        nhorman@...driver.com, alexey.kodanev@...cle.com,
        marcelo.leitner@...il.com
Subject: Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst

From: Tommi Rantala <tommi.t.rantala@...ia.com>
Date: Mon,  5 Feb 2018 15:33:11 +0200

> Fixes: 410f03831 ("sctp: add routing output fallback")
> Signed-off-by: Tommi Rantala <tommi.t.rantala@...ia.com>

I would add another Fixes tag mentioning commit:

	0ca50d12fe46cdf3c0dc9ec5ca98607a52afdc62
	("sctp: fix src address selection if using secondary addresses")

because it is another origin for this dst leak.

Otherwise your patch looks great, please respin it with a second
Fixes: tag added for the above commit and I'll apply this.

Thanks!