netdev - Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180205.212237.773881869579654639.davem@davemloft.net>
Date:   Mon, 05 Feb 2018 21:22:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tommi.t.rantala@...ia.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        nhorman@...driver.com, alexey.kodanev@...cle.com,
        marcelo.leitner@...il.com
Subject: Re: [PATCH net v3] sctp: fix dst refcnt leak in sctp_v4_get_dst

From: Tommi Rantala <tommi.t.rantala@...ia.com>
Date: Mon,  5 Feb 2018 21:48:14 +0200

> Fix dst reference count leak in sctp_v4_get_dst() introduced in commit
> 410f03831 ("sctp: add routing output fallback"):
> 
> When walking the address_list, successive ip_route_output_key() calls
> may return the same rt->dst with the reference incremented on each call.
> 
> The code would not decrement the dst refcount when the dst pointer was
> identical from the previous iteration, causing the dst refcnt leak.
 ...
> Fixes: 410f03831 ("sctp: add routing output fallback")
> Fixes: 0ca50d12f ("sctp: fix src address selection if using secondary addresses")
> Signed-off-by: Tommi Rantala <tommi.t.rantala@...ia.com>

Applied and queued up for -stable, thanks.