netdev - Re: [PATCH] Carrier detect ok, don't turn off negotiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2005408285.4065183.1517935842178@mail.yahoo.com>
Date:   Tue, 6 Feb 2018 16:50:42 +0000 (UTC)
From:   Denis Du <dudenis2000@...oo.ca>
To:     David Miller <davem@...emloft.net>
Cc:     khc@...waw.pl, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Carrier detect ok, don't turn off negotiation



Ok, I submit it  again.


In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the carrier detect still ok, but the protocol will fail. So if carrier detect ok, don't turn off protocol negotiation

This patch is against the kernel version Linux 4.15-rc8





On Tuesday, February 6, 2018, 10:29:53 AM EST, David Miller <davem@...emloft.net> wrote: 





From: Denis Du <dudenis2000@...oo.ca>

Date: Tue, 6 Feb 2018 15:15:28 +0000 (UTC)

> How  do you think my patch?
> 
> As you see, Krzysztof  think my patch is ok to be accepted.
> But if you have a better idea to fix it,I am glad to see it. Anyway, this issue have to be fixed.


Please resubmit it and I'll think about it again, thank you.


View attachment "0001-netdev-carrier-detect-ok-don-t-turn-off-negotiation.patch" of type "text/x-patch" (1258 bytes)