netdev - Re: [PATCH] ss: introduce switch to print exact value of data rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180205170227.1406931f@xeon-e3>
Date:   Mon, 5 Feb 2018 17:02:27 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Tomasz Torcz <tomasz.torcz@...dea.com>, netdev@...r.kernel.org,
        tomek@...ebreaker.pl
Subject: Re: [PATCH] ss: introduce switch to print exact value of data rates

On Fri, 2 Feb 2018 16:32:47 -0700
David Ahern <dsahern@...il.com> wrote:

> On 2/1/18 7:19 AM, Tomasz Torcz wrote:
> >   Introduce -X/--exact switch to disable human-friendly printing
> >  of datarates. With the switch, data is not presented as MBps/Kbps.
> > 
> >   Signed-off-by: Tomasz Torcz <tomasz.torcz@...dea.com>
> > ---
> >  misc/ss.c | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/misc/ss.c b/misc/ss.c
> > index 29a25070..5ca5112a 100644
> > --- a/misc/ss.c
> > +++ b/misc/ss.c
> > @@ -95,6 +95,7 @@ int resolve_services = 1;
> >  int preferred_family = AF_UNSPEC;
> >  int show_options;
> >  int show_details;
> > +int show_exact;  
> 
> show_exact suggests the other versions are not exact. show_raw? or
> 
> int human_readable = 1;
> 
> and -X disables it?

agree with david, think of another flag name (raw? or no-prefix?)