netdev - Re: xfrm, ip tunnel: non released device reference upon device unregistration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180206131509.GA14261@breakpoint.cc>
Date:   Tue, 6 Feb 2018 14:15:09 +0100
From:   Florian Westphal <fw@...len.de>
To:     Steffen Klassert <steffen.klassert@...unet.com>
Cc:     Florian Westphal <fw@...len.de>,
        Eyal Birger <eyal.birger@...il.com>, netdev@...r.kernel.org,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        shmulik@...anetworks.com
Subject: Re: xfrm, ip tunnel: non released device reference upon device
 unregistration

Steffen Klassert <steffen.klassert@...unet.com> wrote:
> I gave the patch a quick try, but still I get this:
> 
> unregister_netdevice: waiting for dummy1 to become free. Usage count = 2

Was that with Eyals setup or the bridge one I posted?

If it was Eyals setup, its possible the patch missed hookup
to whatever tunnel infra is used (the setup I used has ipip tunnel,
everything is ipv4).

Also, perhaps it would be best to not bother with checking the
device in question at all and unconditionally put device reference
of all the dst_caches.  With setups that have e.g. 1k devices going down
per second (ppp dialin and the like) doing the full search for every
notify event would be rather expensive.