netdev - Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180206.111736.1114727374069829674.davem@davemloft.net>
Date:   Tue, 06 Feb 2018 11:17:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     ynorov@...iumnetworks.com, akpm@...ux-foundation.org,
        sfr@...b.auug.org.au, netdev@...r.kernel.org
Subject: Re: Regression in 39461af74125 "bitmap: replace
 bitmap_{from,to}_u32array"

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Mon, 5 Feb 2018 07:21:32 +0100

> Recently ethtool started to give incomplete values for supported and
> advertised modes. There seems to be a regression in this commit:
> The bit number parameter in the calls to bitmap_to_arr32() in
> store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS
> instead of __ETHTOOL_LINK_MODE_MASK_NU32.
> 
> After having changed this ethtool behaves normally again.

I do not see the commit with the SHA1 ID from the Subject line in
either Linus's nor my networking tree.

Where is that change?

[davem@...p-10-15-49-227 linux]$ git show 39461af74125 >x.diff
fatal: ambiguous argument '39461af74125': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
[davem@...p-10-15-49-227 linux]$ cd ../net
[davem@...p-10-15-49-227 net]$ git show 39461af74125 >x.diff
fatal: ambiguous argument '39461af74125': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
[davem@...p-10-15-49-227 net]$