netdev - Re: [PATCH v2 1/1] tcp: Honor the eor bit in tcp_mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180206.112413.190156140626568457.davem@davemloft.net>
Date:   Tue, 06 Feb 2018 11:24:13 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ilyal@...lanox.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, kafai@...com,
        borisp@...lanox.com
Subject: Re: [PATCH v2 1/1] tcp: Honor the eor bit in tcp_mtu_probe

From: Ilya Lesokhin <ilyal@...lanox.com>
Date: Mon,  5 Feb 2018 20:18:32 +0200

> Avoid SKB coalescing if eor bit is set in one of the relevant
> SKBs.
> 
> Fixes: c134ecb87817 ("tcp: Make use of MSG_EOR in tcp_sendmsg")
> Signed-off-by: Ilya Lesokhin <ilyal@...lanox.com>

This adds a build warning, please fix:

  CC      net/ipv4/tcp_output.o
In file included from ./include/linux/tcp.h:21:0,
                 from ./include/net/tcp.h:24,
                 from net/ipv4/tcp_output.c:39:
net/ipv4/tcp_output.c: In function ‘tcp_write_xmit’:
./include/linux/skbuff.h:3196:12: warning: ‘skb’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   for (tmp = skb->next;      \
            ^
net/ipv4/tcp_output.c:2043:18: note: ‘skb’ was declared here
  struct sk_buff *skb, *nskb, *next;
                  ^~~

This is with:

[davem@...p-10-15-49-227 net]$ gcc --version
gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[davem@...p-10-15-49-227 net]$