netdev - Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 06 Feb 2018 11:42:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ynorov@...iumnetworks.com
Cc:     hkallweit1@...il.com, akpm@...ux-foundation.org,
        sfr@...b.auug.org.au, netdev@...r.kernel.org
Subject: Re: Regression in 39461af74125 "bitmap: replace
 bitmap_{from,to}_u32array"

From: Yury Norov <ynorov@...iumnetworks.com>
Date: Tue, 6 Feb 2018 19:26:23 +0300

> On Tue, Feb 06, 2018 at 11:17:36AM -0500, David Miller wrote:
>> From: Heiner Kallweit <hkallweit1@...il.com>
>> Date: Mon, 5 Feb 2018 07:21:32 +0100
>> 
>> > Recently ethtool started to give incomplete values for supported and
>> > advertised modes. There seems to be a regression in this commit:
>> > The bit number parameter in the calls to bitmap_to_arr32() in
>> > store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS
>> > instead of __ETHTOOL_LINK_MODE_MASK_NU32.
>> > 
>> > After having changed this ethtool behaves normally again.
>> 
>> I do not see the commit with the SHA1 ID from the Subject line in
>> either Linus's nor my networking tree.
>> 
>> Where is that change?
> 
> It's in next-20180202.

Hmmm, then the fix should probably go into whatever tree that commit
ultimately came from.