netdev - Re: [PATCH net v2] net: phy: fix phy_start to consider PHY_IGNORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d05322a-5b34-0d6c-2ed8-0a2b8152c8fa@gmail.com>
Date:   Wed, 7 Feb 2018 15:00:05 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net v2] net: phy: fix phy_start to consider
 PHY_IGNORE_INTERRUPT

On 02/07/2018 11:44 AM, Heiner Kallweit wrote:
> This condition wasn't adjusted when PHY_IGNORE_INTERRUPT (-2) was added
> long ago. In case of PHY_IGNORE_INTERRUPT the MAC interrupt indicates
> also PHY state changes and we should do what the symbol says.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> v2:
> - use phy_interrupt_is_valid() instead of checking for irq > 0

Thanks, could you identify which Fixes: tag we should be using for that?
It would be great to see this backported to -stable

> ---
>  drivers/net/phy/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index f3313a129..50ed35a45 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -822,7 +822,7 @@ void phy_start(struct phy_device *phydev)
>  		phy_resume(phydev);
>  
>  		/* make sure interrupts are re-enabled for the PHY */
> -		if (phydev->irq != PHY_POLL) {
> +		if (phy_interrupt_is_valid(phydev)) {
>  			err = phy_enable_interrupts(phydev);
>  			if (err < 0)
>  				break;
> 


-- 
Florian