netdev - Re: Re: [Android][Kernel][TCP/IP] report of packet discarding during tcp handshaking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1518014640.3715.157.camel@gmail.com>
Date:   Wed, 07 Feb 2018 06:44:00 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     soukjin.bae@...sung.com,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     유금환 <geumhwan.yu@...sung.com>,
        안치훈 <ch.ahn@...sung.com>
Subject: Re: Re: [Android][Kernel][TCP/IP] report of packet discarding
 during tcp handshaking

On Wed, 2018-02-07 at 16:19 +0900, 배석진 wrote:
> Dear Dumazet,
> 
> 
> although with your changes, the problem still there.
> own_req couldn't update the lost_race as you wanted.
> maybee it needs additional locking method.
> 

We are not going to add udelay(500) in a loop to solve a race, sorry.

My patch should work, because the lost_race is true means that the
other cpu had put its new (full blown) socket into the hash table.

So this cpu should find it while doing its second lookup.

If not, too bad. Maybe socket has already been accept() and close()