netdev - Re: [PATCH net] netlink: ensure to loop over all netns in genlmsg_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180208.140628.1811297965761970476.davem@redhat.com>
Date:   Thu, 08 Feb 2018 14:06:28 -0500 (EST)
From:   David Miller <davem@...hat.com>
To:     nicolas.dichtel@...nd.com
Cc:     netdev@...r.kernel.org, johannes.berg@...el.com
Subject: Re: [PATCH net] netlink: ensure to loop over all netns in
 genlmsg_multicast_allns()

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Tue,  6 Feb 2018 14:48:32 +0100

> Nowadays, nlmsg_multicast() returns only 0 or -ESRCH but this was not the
> case when commit 134e63756d5f was pushed.
> However, there was no reason to stop the loop if a netns does not have
> listeners.
> Returns -ESRCH only if there was no listeners in all netns.
> 
> To avoid having the same problem in the future, I didn't take the
> assumption that nlmsg_multicast() returns only 0 or -ESRCH.
> 
> Fixes: 134e63756d5f ("genetlink: make netns aware")
> CC: Johannes Berg <johannes.berg@...el.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Ok, that indeed preserves the original behavior.  Given this has
been this way since 2.6.32 I wonder if fixing this might break
something.

Regardless, applied and queued up for -stable, thanks.