netdev - Re: [PATCH v3 1/1] tcp: Honor the eor bit in tcp_mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180208.143750.1594644041832386882.davem@davemloft.net>
Date:   Thu, 08 Feb 2018 14:37:50 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ilyal@...lanox.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, kafai@...com,
        borisp@...lanox.com
Subject: Re: [PATCH v3 1/1] tcp: Honor the eor bit in tcp_mtu_probe

From: Ilya Lesokhin <ilyal@...lanox.com>
Date: Wed,  7 Feb 2018 15:13:11 +0200

> +static bool tcp_can_coalesce_send_queue_head(struct sock *sk, int len)
> +{
> +	struct sk_buff *skb, *next;
> +
> +	skb = tcp_send_head(sk);
> +	tcp_for_write_queue_from_safe(skb, next, sk)
> +	{

Please format tcp_for_write_queue_from_safe() uses like a real for loop,
meaning that the openning curly braces go on the same line as the
tcp_for_write_queue_from_safe() statement.

Thank you.