netdev - Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfae1bda-9ccd-6a48-95f9-e061c1bd3828@denx.de>
Date:   Thu, 8 Feb 2018 20:22:54 +0100
From:   Marek Vasut <marex@...x.de>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        Heiko Schocher <hs@...x.de>, linux-can@...r.kernel.org
Cc:     Markus Marb <markus@...b.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Wolfgang Grandegger <wg@...ndegger.com>
Subject: Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote:
> On 02/08/2018 07:47 AM, Heiko Schocher wrote:
>> the driver reads in the ISR first the IRQpending register,
>> and clears after that in a write *all* bits in it.
>>
>> It could happen that the isr register raise bits between
>> this 2 register accesses, which leads in lost bits ...
>>
>> In case it clears "TX message sent successfully", the driver
>> never sends any Tx data, and buffers to userspace run over.
>>
>> Fixed this:
>> clear only the bits in the IRQpending register, the
>> driver had read.
>>
>> Signed-off-by: Heiko Schocher <hs@...x.de>
>> Reviewed-by: Marek Vasut <marex@...x.de>
> 
> Applied both to linux-can.

Can you also apply them to stable, so they get into 4.9.x etc ?

Thanks!

-- 
Best regards,
Marek Vasut