netdev - Re: [PATCH] mpls, nospec: Sanitize array index in mpls_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180208.152430.815938637029162565.davem@davemloft.net>
Date:   Thu, 08 Feb 2018 15:24:30 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dan.j.williams@...el.com
Cc:     netdev@...r.kernel.org, ebiederm@...ssion.com,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mpls, nospec: Sanitize array index in mpls_label_ok()

From: Dan Williams <dan.j.williams@...el.com>
Date: Wed, 07 Feb 2018 22:34:24 -0800

> mpls_label_ok() validates that the 'platform_label' array index from a
> userspace netlink message payload is valid. Under speculation the
> mpls_label_ok() result may not resolve in the CPU pipeline until after
> the index is used to access an array element. Sanitize the index to zero
> to prevent userspace-controlled arbitrary out-of-bounds speculation, a
> precursor for a speculative execution side channel vulnerability.
> 
> Cc: <stable@...r.kernel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Applied, thank you.