netdev - Re: [PATCH v1 1/1] spi_ks8995: use regmap to access chip registers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180207.214916.370684288901847015.davem@davemloft.net>
Date:   Wed, 07 Feb 2018 21:49:16 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     svendev@...x.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, helmut.buchsbaum@...il.com,
        Maarten.Blomme@...r.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v1 1/1] spi_ks8995: use regmap to access chip registers.

From: Sven Van Asbroeck <svendev@...x.com>
Date: Tue, 6 Feb 2018 10:13:56 -0500

> The register map layouts used in this driver are well suited to
> being accessed through a regmap. This makes the driver simpler
> and shorter, by eliminating some spi boilerplate code.
> 
> Testing:
> - tested on a ksz8785.
> - not tested on the other supported chips (ks8995, ksz8864)
>   because I don't have access to them.
>   However, I instrumented the spi layer to verify that the
>   correct spi transactions are generated to read the ID
>   registers on those chips.
> 
> Signed-off-by: Sven Van Asbroeck <svendev@...x.com>

Please resubmit this simplification when the net-next tree opens
back up.

Thank you.