netdev - Re: [PATCH net] net/ipv6: onlink nexthop checks should default to main table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180207.215308.313730350500733345.davem@davemloft.net>
Date:   Wed, 07 Feb 2018 21:53:08 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net/ipv6: onlink nexthop checks should default to
 main table

From: David Ahern <dsahern@...il.com>
Date: Tue,  6 Feb 2018 13:17:06 -0800

> Because of differences in how ipv4 and ipv6 handle fib lookups,
> verification of nexthops with onlink flag need to default to the main
> table rather than the local table used by IPv4. As it stands an
> address within a connected route on device 1 can be used with
> onlink on device 2. Updating the table properly rejects the route
> due to the egress device mismatch.
> 
> Update the extack message as well to show it could be a device
> mismatch for the nexthop spec.
> 
> Fixes: fc1e64e1092f ("net/ipv6: Add support for onlink flag")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied, thanks David.