netdev - Re: [PATCH net] tcp: tracepoint: only call trace_tcp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 07 Feb 2018 22:01:17 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     songliubraving@...com
Cc:     netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net] tcp: tracepoint: only call trace_tcp_send_reset
 with full socket

From: Song Liu <songliubraving@...com>
Date: Tue, 6 Feb 2018 20:50:23 -0800

> tracepoint tcp_send_reset requires a full socket to work. However, it
> may be called when in TCP_TIME_WAIT:
> 
>         case TCP_TW_RST:
>                 tcp_v6_send_reset(sk, skb);
>                 inet_twsk_deschedule_put(inet_twsk(sk));
>                 goto discard_it;
> 
> To avoid this problem, this patch checks the socket with sk_fullsock()
> before calling trace_tcp_send_reset().
> 
> Fixes: c24b14c46bb8 ("tcp: add tracepoint trace_tcp_send_reset")
> Signed-off-by: Song Liu <songliubraving@...com>
> Reviewed-by: Lawrence Brakmo <brakmo@...com>

Applied and queued up for -stable, thank you.