netdev - Re: [PATCH net V2 1/2] ptr_ring: try vmalloc() when kmalloc() fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73b17c4f-7deb-f764-be1c-ab6f3c502d41@redhat.com>
Date:   Thu, 8 Feb 2018 11:26:57 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     mst@...hat.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net V2 1/2] ptr_ring: try vmalloc() when kmalloc() fails



On 2018年02月08日 11:21, Jason Wang wrote:
> This patch switch to use kvmalloc_array() for using a vmalloc()
> fallback to help in case kmalloc() fails.
>
> Reported-by: syzbot+e4d4f9ddd4295539735d@...kaller.appspotmail.com
> Fixes: 2e0ab8ca83c12 ("ptr_ring: array based FIFO for pointers")
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> ---
>   include/linux/ptr_ring.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h
> index 1883d61..9c3b748 100644
> --- a/include/linux/ptr_ring.h
> +++ b/include/linux/ptr_ring.h
> @@ -466,7 +466,7 @@ static inline int ptr_ring_consume_batched_bh(struct ptr_ring *r,
>   
>   static inline void **__ptr_ring_init_queue_alloc(unsigned int size, gfp_t gfp)
>   {
> -	return kcalloc(size, sizeof(void *), gfp);
> +	return kvmalloc_array(size, sizeof(void *), gfp | __GFP_ZERO);
>   }
>   
>   static inline void __ptr_ring_set_size(struct ptr_ring *r, int size)

Forget the kvfree() ...

Will post V3.

Sorry.