netdev - Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180209113203.2608d3f9@cakuba.netronome.com>
Date:   Fri, 9 Feb 2018 11:32:03 -0800
From:   Jakub Kicinski <kubakici@...pl>
To:     Nathan Fontenot <nfont@...ux.vnet.ibm.com>
Cc:     netdev@...r.kernel.org, jallen@...ux.vnet.ibm.com,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH] ibmvnic: Remove skb->protocol checks in ibmvnic_xmit

On Fri, 09 Feb 2018 13:09:34 -0600, Nathan Fontenot wrote:
> From: John Allen (jallen@...ux.vnet.ibm.com>

Nit: s/(/</

> Having these checks in ibmvnic_xmit causes problems with VLAN
> tagging and balance-alb/tlb bonding modes. The restriction they
> imposed can be removed.
> 
> Signed-off-by: Nathan Fontenot <nfont@...ux.vnet.ibm.com>

Patch does not have author's SoB line, the kernel bots will complain
about this, so please add it if it's not a problem.