netdev - Re: [PATCH iproute2-next] ip/tunnel: Minor cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e9becb6-aa30-fd14-e3a2-b4fb565e87c2@gmail.com>
Date:   Fri, 9 Feb 2018 09:12:15 -0700
From:   David Ahern <dsahern@...il.com>
To:     Serhey Popovych <serhe.popovych@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip/tunnel: Minor cleanups

On 2/8/18 3:57 AM, Serhey Popovych wrote:
> Few minor changes to reduce diffs between ip and ipv6 tunnel code:
> 
>   1) reduce intendation by one level when adding attributes in gre and
>      gre6; reorder addattr*() calls to simplify diff
> 
>   2) reorder local variables definition; change their type (e.g. for
>      IFLA_LINK) to match ones returned by rta_getattr_*()
> 
>   3) move "mode" parameter parsing in link_iptnl.c to the similar
>      position as in link_ip6tnl.c
> 
>   4) handle "tc" as shortcut for "tclass"/"tos" in link_iptnl.c
> 
>   5) add whitespace where required
> 
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>
> ---
>  ip/link_gre.c    |   91 +++++++++++++++++++++++++++---------------------------
>  ip/link_gre6.c   |   83 ++++++++++++++++++++++++-------------------------
>  ip/link_ip6tnl.c |   13 ++++----
>  ip/link_iptnl.c  |   61 ++++++++++++++++++------------------
>  ip/link_vti.c    |    2 +-
>  ip/link_vti6.c   |    2 +-
>  6 files changed, 127 insertions(+), 125 deletions(-)
> 

applied to iproute2-next.

That is a large change for a single patch. Please send future cleanups
with grouped changes like you have done for other patches. gre/gr6 in
one patch, vti /vti6 in a second, etc.