netdev - Re: [Q] Unable to load SCHED_CLS/SCHED_ACT bpf programs from outside init_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9500f88-2484-b03b-e199-ede532d48b26@iogearbox.net>
Date:   Sat, 10 Feb 2018 14:08:58 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Shmulik Ladkani <shmulik@...anetworks.com>,
        Alexei Starovoitov <ast@...nel.org>
Cc:     Chenbo Feng <fengc@...gle.com>, eyal@...anetworks.com,
        netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [Q] Unable to load SCHED_CLS/SCHED_ACT bpf programs from outside
 init_user_ns

Hi Shmulik,

On 02/10/2018 08:46 AM, Shmulik Ladkani wrote:
> Hi,
> 
> Apparently one cannot use TC cls_bpf/act_bpf if running from a user ns
> other than the init_user_ns, as bpf_prog_load does not permit loading
> these type of progs, snip:
> 
>         if (type != BPF_PROG_TYPE_SOCKET_FILTER &&
>             type != BPF_PROG_TYPE_CGROUP_SKB &&
>             !capable(CAP_SYS_ADMIN))
>                 return -EPERM;
> 
> although the user performing BPF_PROG_LOAD has both CAP_SYS_ADMIN (and
> CAP_NET_ADMIN, as required by RTM_NEWTFILTER) in his current_user_ns.
> 
> This prevents using tc cls_bpf/act_bpf in containerized software
> stacks (where in contrast other tc cls/act are permitted).

Not really, it's correct that it's initns root-only, but for containers
control plane can attach BPF progs out of initns into the host-facing
veth on ingress/egress clsact side to enforce policy, mangle packets etc.
The other option you would have is that controller would load and pin
the prog as a node into BPF fs and you can then get the fd and attach
it to to the veth inside the netns if this is what you're after (the
attach itself in the second step does not require anything extra compared
to rest of tc) provided the mount is shared at setup time (but could
later be removed in the container for example). In future it might be
subject to change to also enable it for userns under the constraint that
verifier puts more restrictions in place in roughly similar fashion to
current unpriv program types, that work just hasn't been tackled yet.

Thanks,
Daniel

> The original restiction comes from
>     1be7f75d1668 "bpf: enable non-root eBPF programs"
> quote:
>     tracing and tc cls/act program types still require root permissions,
>     since tracing actually needs to be able to see all kernel pointers
>     and tc is for root only.
> 
> Can the restriction be relaxed, as done for TYPE_SOCKET_FILTER and later
> for TYPE_CGROUP_SKB?
> 
> Are the SCHED_CLS/SCHED_ACT progs still suspectable of leaking kernel
> pointers?
> If so, can we restrict only certain operations which are guaranteed not
> to leak, so that tc cls_bpf/act_bpf can still be used outside
> init_user_ns?
> 
> Thanks,
> Shmulik