netdev - Re: [PATCH net-next v2 01/16] l2tp: update sk_user_data while holding sk_callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180212.112129.1458610223636502379.davem@davemloft.net>
Date:   Mon, 12 Feb 2018 11:21:29 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jchapman@...alix.com
Cc:     netdev@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH net-next v2 01/16] l2tp: update sk_user_data while
 holding sk_callback_lock

From: James Chapman <jchapman@...alix.com>
Date: Mon, 12 Feb 2018 10:11:05 +0000

> Since L2TP hooks on sockets opened by userspace using sk_user_data, we
> may race with other socket families that attempt to use the same
> socket.
> 
> This problem was discovered by syzbot using AF_KCM. KCM has since been
> modified to use only TCP sockets to avoid hitting this issue but we
> should prevent such races in L2TP anyway.
> 
> Fixes: c8fffcea0a079 ("l2tp: Refactor l2tp core driver to make use of the common UDP tunnel function")
> Reported-by: syzbot+8865eaff7f9acd593945@...kaller.appspotmail.com

Yikes.  Where is your signoff James?

> Kernel BUG at net/l2tp/l2tp_ppp.c:176!
> invalid opcode: 0000 [#1] SMP KASAN
> Dumping ftrace buffer:
>    (ftrace buffer empty)

And this oops dump should be before the various
fixes/reported-by/signed-off-by tags.

Thanks.