netdev - Re: [PATCH net-next v2 03/16] l2tp: don't use inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <889ee2f7-d43a-ec75-1bf5-919da524e766@katalix.com>
Date:   Mon, 12 Feb 2018 17:23:44 +0000
From:   James Chapman <jchapman@...alix.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 03/16] l2tp: don't use inet_shutdown on tunnel
 destroy

On 12/02/18 16:22, David Miller wrote:
> From: James Chapman <jchapman@...alix.com>
> Date: Mon, 12 Feb 2018 10:11:07 +0000
>
>> Previously, if a tunnel was closed, we called inet_shutdown to mark
>> the socket as unconnected such that userspace would get errors and
>> then close the socket. This could race with userspace closing the
>> socket. Instead, leave userspace to close the socket in its own time
>> (our tunnel will be detached anyway).
>>
>> Fixes: 309795f4be ("l2tp: Add netlink control API for L2TP")
>  ...
>>  BUG: unable to handle kernel NULL pointer dereference at 00000000000000a0
>>  IP: __lock_acquire+0x263/0x1630
> Ok, all of these are like this.
>
> Please fix this up, put the kernel log message into the message body
> and add an appropriate signoff.
>
> Thank you.

Oh stupid me. I'll do so straight away. Sorry!