lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 12 Feb 2018 09:29:11 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Finn Thain <fthain@...egraphics.com.au> Cc: "David S. Miller" <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, "Linux/m68k" <linux-m68k@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net v4 09/13] net/mac8390: Convert to nubus_driver On Mon, Feb 12, 2018 at 4:08 AM, Finn Thain <fthain@...egraphics.com.au> wrote: > This resolves an old bug that constrained this driver to no more than > one card. > > Tested-by: Stan Johnson <userm57@...oo.com> > Signed-off-by: Finn Thain <fthain@...egraphics.com.au> > --- a/drivers/net/ethernet/8390/mac8390.c > +++ b/drivers/net/ethernet/8390/mac8390.c > @@ -390,86 +389,86 @@ static bool __init mac8390_init(struct net_device *dev, > return true; > } > > -struct net_device * __init mac8390_probe(int unit) > +static int mac8390_device_probe(struct nubus_board *board) > { > struct net_device *dev; > - struct nubus_rsrc *ndev = NULL; > int err = -ENODEV; > - static unsigned int slots; > - > - enum mac8390_type cardtype; > - > - /* probably should check for Nubus instead */ > + struct nubus_rsrc *fres; > + enum mac8390_type cardtype = MAC8390_NONE; > > if (!MACH_IS_MAC) > - return ERR_PTR(-ENODEV); > + return -ENODEV; I think this check can be removed completely, as the nubus_board will exist on suitable Macs only. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists