netdev - Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN conversion in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180212122957.GJ7402@localhost.localdomain>
Date:   Mon, 12 Feb 2018 10:29:57 -0200
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        davem@...emloft.net, Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH net] sctp: add SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN
 conversion in sctp_cname

On Mon, Feb 12, 2018 at 06:29:51PM +0800, Xin Long wrote:
> After the support for SCTP_CID_I_DATA and SCTP_CID_I_FWD_TSN chunks,
> the corresp conversion in sctp_cname should also be added. Otherwise,
> in some places, pr_debug will print them as "unknown chunk".
> 
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

> ---
>  net/sctp/debug.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/sctp/debug.c b/net/sctp/debug.c
> index 291c97b..8f6c2e8 100644
> --- a/net/sctp/debug.c
> +++ b/net/sctp/debug.c
> @@ -81,6 +81,12 @@ const char *sctp_cname(const union sctp_subtype cid)
>  	case SCTP_CID_RECONF:
>  		return "RECONF";
>  
> +	case SCTP_CID_I_DATA:
> +		return "I_DATA";
> +
> +	case SCTP_CID_I_FWD_TSN:
> +		return "I_FWD_TSN";
> +
>  	default:
>  		break;
>  	}
> -- 
> 2.1.0
>