netdev - Re: [PATCH net] netfilter: nat: cope with negative port range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Feb 2018 18:22:35 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org, Pablo Neira Ayuso <pablo@...filter.org>,
        "David S. Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH net] netfilter: nat: cope with negative port range

On Tue, 2018-02-13 at 18:02 +0100, Florian Westphal wrote:
> Paolo Abeni <pabeni@...hat.com> wrote:
> > Fixes: c7232c9979cb ("netfilter: add protocol independent NAT core")
> 
> are you sure?
> When I looked this was a day 0 bug, the code was just moved from ipv4.

You are right, the named commit just move around the bugged code, the
bug is apparently there since:

commit 5b1158e909ecbe1a052203e0d8df15633f829930
Author: Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
Date:   Sat Dec 2 22:07:13 2006 -0800

    [NETFILTER]: Add NAT support for nf_conntrack

I'll send a v2 with an updated commit message, thanks!

Paolo