netdev - Re: [PATCH V2 net-next] rds: do not call ->conn_alloc with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3f5f30f-0ac8-1473-f03d-5afcfa0df4cb@oracle.com>
Date:   Tue, 13 Feb 2018 09:38:48 -0800
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Sowmini Varadhan <sowmini.varadhan@...cle.com>,
        netdev <netdev@...r.kernel.org>
Cc:     "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH V2 net-next] rds: do not call ->conn_alloc with GFP_KERNEL


On 2/13/2018 9:05 AM, Sowmini Varadhan wrote:
> Commit ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize
> netns/module teardown and rds connection/workq management")
> adds an rcu read critical section to __rd_conn_create. The
> memory allocations in that critcal section need to use
> GFP_ATOMIC to avoid sleeping.
> 
> This patch was verified with syzkaller reproducer.
> 
> Fixes: ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize
>         netns/module teardown and rds connection/workq management")
> Reported-by: syzbot+a0564419941aaae3fe3c@...kaller.appspotmail.com
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>